Skip to content

GH-46477: [C++] Use vendored flatbuffers in Meson configuration #46484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented May 17, 2025

Rationale for this change

This makes it easier to submit Arrow as a wrapdb entry, as the external flatbuffers version is difficult to control. Since it isn't used to generate the flatc files contained within the repo, it is better to just stick with the vendored headers

What changes are included in this PR?

Removed flatbuffers Meson subproject and use internal dependency

Are these changes tested?

Yes

Are there any user-facing changes?

No

@WillAyd
Copy link
Contributor Author

WillAyd commented May 17, 2025

@github-actions crossbow submit *meson

Copy link

⚠️ GitHub issue #46477 has been automatically assigned in GitHub to PR creator.

Copy link

Revision: 5b970d8

Submitted crossbow builds: ursacomputing/crossbow @ actions-7f4a2305f5

Task Status
test-conda-cpp-meson GitHub Actions

@WillAyd
Copy link
Contributor Author

WillAyd commented May 27, 2025

@kou if you have a chance to look at this, this one would be helpful to continue work upstream in Meson's wrapdb to make arrow natively available

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 87a1ab4 into apache:main May 28, 2025
35 of 37 checks passed
@kou kou removed the awaiting review Awaiting review label May 28, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants